sijie commented on a change in pull request #643: BP-14 part 2 - client side
changes
URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145536889
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
##########
@@ -84,15 +85,32 @@
final BookKeeper bk;
final long ledgerId;
long lastAddPushed;
+ /**
+ * Last entryId which has been confirmed to be written durably to the
bookies.
+ * This value is used by readers, the the LAC protocol
+ */
volatile long lastAddConfirmed;
+ /**
+ * Last entryId which has been confirmed to be written durably to the
bookies,
+ * this is an internal variable used to track the status of entries and
to handle correcly the lastAddConfirmed
+ * value
+ */
+ volatile long lastAddSynced;
Review comment:
why do you need additional `lastAddSynced` here? isn't that same as
`lastAddConfirmed`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
