sijie commented on a change in pull request #643: BP-14 part 2 - client side
changes
URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145534806
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/AsyncCallback.java
##########
@@ -160,6 +160,25 @@ void readComplete(int rc, LedgerHandle lh,
Enumeration<LedgerEntry> seq,
}
/**
+ * Async Callback for handling sync responses
+ *
+ * @since 4.0
+ */
+ @InterfaceAudience.Private
Review comment:
why this is `Private`? If it is private, you should not add this interface
in `AsyncCallback`. all the classes in `AsyncCallback` are supposed to be
public.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
