[
https://issues.apache.org/jira/browse/CALCITE-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14744696#comment-14744696
]
Josh Elser commented on CALCITE-840:
------------------------------------
[~jnadeau], thanks for the great write up. I appreciate your thoughts.
bq. create a separate module that is pb only and use a special profile to
generate compilations (and add headers)
I think Julian and I touched on this one already. In splitting up the jackson
annotations, we both agreed that it would be good to move JSON stuff into one
maven module and Protobuf stuff into another module. Thinking some more, we'll
have to mess with the packaging a bit (instead of the shaded jar being
generated in the avatica module). That's something we can work around, though.
bq. That being said, I would suggest that if you haven't already gone way down
a path, consider using the protostuf generated files
Hah, dang. A little too late. Not to say we can investigate further, but I've
quite dealt with protobuf's builder pattern all over.
bq. We use this in Drill to be able to move back and forth between json and
protobuf as requirements dictate
My hope is that protobuf3 will include a good JSON serialization natively (and
will help reduce the dependency footprint), but time will be the ultimate tell
here.
Speaking of dependencies though, I need to update the LICENSE and NOTICE files
too. Including protocol buffers means that the top-level L&N files are wrong as
well as the L&N for the shaded calcite-avatica jar.
> Protobuf transport for Avatica
> ------------------------------
>
> Key: CALCITE-840
> URL: https://issues.apache.org/jira/browse/CALCITE-840
> Project: Calcite
> Issue Type: Bug
> Components: avatica
> Reporter: Julian Hyde
> Assignee: Josh Elser
> Fix For: 1.5.0-incubating
>
> Attachments: CALCITE-840.001.patch, CALCITE-840.002.patch,
> CALCITE-840.003.patch, CALCITE-840.004.patch
>
>
> Create a transport for Avatica that uses Protobuf.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
