[
https://issues.apache.org/jira/browse/CALCITE-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14744597#comment-14744597
]
Jacques Nadeau commented on CALCITE-840:
----------------------------------------
Hey Guys,
Sorry I didn't see the query earlier. My theory: don't check in anything that
is derived. Cruel Reality: Remove all barriers for new users. A number of new
developers didn't read the instructions and then got stuck rather than solving
(or reading the error message). We had an especially big problem because we
were using PB 2.5 when everyone else was on 2.4. Everybody is on 2.5 now so we
could probably stop including the files. That being said, the ease for new
developers still trumps. With 3.x coming out, I'd recommend doing the same as
we do on Drill. Specifically: create a separate module that is pb only and use
a special profile to generate compilations (and add headers). I'd just pick up
this: [1]. Note, you can remove the extra stuff for protostuf if you like. That
being said, I would suggest that if you haven't already gone way down a path,
consider using the protostuf generated files. They give you beans (instead of
builders) as well as a nice transformation between json and protobuf. We use
this in Drill to be able to move back and forth between json and protobuf as
requirements dictate.
[1] https://github.com/apache/drill/blob/master/protocol/pom.xml
> Protobuf transport for Avatica
> ------------------------------
>
> Key: CALCITE-840
> URL: https://issues.apache.org/jira/browse/CALCITE-840
> Project: Calcite
> Issue Type: Bug
> Components: avatica
> Reporter: Julian Hyde
> Assignee: Josh Elser
> Fix For: 1.5.0-incubating
>
> Attachments: CALCITE-840.001.patch, CALCITE-840.002.patch,
> CALCITE-840.003.patch, CALCITE-840.004.patch
>
>
> Create a transport for Avatica that uses Protobuf.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
