[
https://issues.apache.org/jira/browse/CALCITE-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14744274#comment-14744274
]
Julian Hyde commented on CALCITE-840:
-------------------------------------
1. I fixed errors about unused dependencies, see
https://github.com/julianhyde/incubator-calcite/tree/840-profobuf
2. In
https://github.com/joshelser/incubator-calcite/commit/0f7086cdeb67a397666ed62a56f0da33ebb74640
did you intend to remote the Apache headers?
As generated files, what should the license of these files be?
3. You added several equals() methods, but you don't seem to check for 'this ==
o' before diving into a field-by-field check. This is the norm (e.g.
java.lang.String and java.util.AbstractList do it), and in fact
JsonSerive.finagle(Meta.Signature) relies on it for performance. Can you change
these methods to this general pattern:
{code}
if (o == this) {
return true;
}
if (!(o instanceof TheType)) {
return false;
}
...
{code}
> Protobuf transport for Avatica
> ------------------------------
>
> Key: CALCITE-840
> URL: https://issues.apache.org/jira/browse/CALCITE-840
> Project: Calcite
> Issue Type: Bug
> Components: avatica
> Reporter: Julian Hyde
> Assignee: Josh Elser
> Fix For: 1.5.0-incubating
>
> Attachments: CALCITE-840.001.patch, CALCITE-840.002.patch,
> CALCITE-840.003.patch, CALCITE-840.004.patch
>
>
> Create a transport for Avatica that uses Protobuf.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
