[
https://issues.apache.org/jira/browse/CALCITE-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14952337#comment-14952337
]
YeongWei commented on CALCITE-705:
----------------------------------
Hi [~julianhyde]
I have rebased onto master, please refer to the commit below,
https://github.com/yeongwei/incubator-calcite/commit/1dce44ad24301e4dac16e1f248c499ffbd8ff445
Additionally I have created a pull request,
https://github.com/apache/incubator-calcite/pull/145
1 item that may require you attention, please refer to
AbstractCursor#BinaryAccessor, during the serialization with PROTOBUF, upon
invoking the resultSet.getBytes the underlying object is already of type
byte[], upon casting it to ByteString gives error, I have modified as below,
{code}
public byte[] getBytes() {
Object obj = getObject();
try {
final ByteString o = (ByteString) obj;
return o == null ? null : o.getBytes();
} catch (Exception ex) {
return obj == null ? null : (byte[]) obj;
}
}
{code}
Previously, on JDBC the finagle method did the job of handling the types
properly. Let me know what do you think.
This WIP has passed the "mvn test" and "mvn site".
Thanks!
> AvaticaStatement execute method to support DML
> ----------------------------------------------
>
> Key: CALCITE-705
> URL: https://issues.apache.org/jira/browse/CALCITE-705
> Project: Calcite
> Issue Type: New Feature
> Components: avatica
> Reporter: YeongWei
> Assignee: Julian Hyde
> Fix For: next
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
