[
https://issues.apache.org/jira/browse/CALCITE-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14959123#comment-14959123
]
YeongWei commented on CALCITE-705:
----------------------------------
Hi [~julianhyde]
Please refer below about the remaining items,
{quote}
1. why is JdbcFrontLinqBackTest.testInsert disabled?
2. why is JdbcFrontLinqBackTest.testInsert2 disabled?
{quote}
Both 1 and 2, currently the CalciteAssert uses the executeQuery, but for DML
this will cause the exception of "Expecting Result Set" to be thrown, since the
DML no longer returns the value of "ROWCOUNT=<INT>".
May I suggest that to fix the CalciteAssert via a separate JIRA? As the fix
could impact a lot more unit test.
{quote}
3. Fine to disable JsonHandlerTest.testFetchRequestWithNumberParameter
but you need to add testExecuteRequestWithNumberParameter
{quote}
Let me look into this and submit the Unit Test
Let me know what you think.
Thanks!
> AvaticaStatement execute method to support DML
> ----------------------------------------------
>
> Key: CALCITE-705
> URL: https://issues.apache.org/jira/browse/CALCITE-705
> Project: Calcite
> Issue Type: New Feature
> Components: avatica
> Reporter: YeongWei
> Assignee: Julian Hyde
> Fix For: next
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
