[ 
https://issues.apache.org/jira/browse/CALCITE-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14958609#comment-14958609
 ] 

Julian Hyde commented on CALCITE-705:
-------------------------------------

I reviewed this, rebased and did some cosmetic cleanups. See 
https://github.com/julianhyde/incubator-calcite/tree/705-execute.

Looks good, and all tests pass. 3 small remaining issues:
* why is JdbcFrontLinqBackTest.testInsert disabled?
* why is JdbcFrontLinqBackTest.testInsert2 disabled?
* Fine to disable JsonHandlerTest.testFetchRequestWithNumberParameter
  but you need to add testExecuteRequestWithNumberParameter.

I'll let [~elserj] decide how to resolve the byte[] vs ByteString issue, and I 
think it can after this change is committed.

> AvaticaStatement execute method to support DML
> ----------------------------------------------
>
>                 Key: CALCITE-705
>                 URL: https://issues.apache.org/jira/browse/CALCITE-705
>             Project: Calcite
>          Issue Type: New Feature
>          Components: avatica
>            Reporter: YeongWei
>            Assignee: Julian Hyde
>             Fix For: next
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to