SteNicholas commented on code in PR #3132:
URL: https://github.com/apache/celeborn/pull/3132#discussion_r1986551155
##########
client/src/main/java/org/apache/celeborn/client/read/PartitionReader.java:
##########
@@ -21,14 +21,21 @@
import io.netty.buffer.ByteBuf;
+import
org.apache.celeborn.client.read.checkpoint.PartitionReaderCheckpointMetadata;
import org.apache.celeborn.common.protocol.PartitionLocation;
-public interface PartitionReader {
+public interface PartitionReader<T extends PartitionReaderCheckpointMetadata> {
boolean hasNext();
ByteBuf next() throws IOException, InterruptedException;
void close();
PartitionLocation getLocation();
+
+ default T getPartitionReaderCheckpointMetadata() {
Review Comment:
Why does this method has default implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
