FMX commented on code in PR #3132:
URL: https://github.com/apache/celeborn/pull/3132#discussion_r1986563198
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -982,6 +982,13 @@ class CelebornConf(loadDefaults: Boolean) extends
Cloneable with Logging with Se
def clientFetchTimeoutMs: Long = get(CLIENT_FETCH_TIMEOUT)
def clientFetchBufferSize: Int = get(CLIENT_FETCH_BUFFER_SIZE).toInt
def clientFetchMaxReqsInFlight: Int = get(CLIENT_FETCH_MAX_REQS_IN_FLIGHT)
+ def isWorkerPartitionReaderCheckpointEnabled: Boolean = {
+ if (clientPushReplicateEnabled) {
+ false
+ } else
+ get(WORKER_PARTITION_READER_CHECKPOINT_ENABLE)
Review Comment:
Save it to a val to avoid repeatedly parsing this config
##########
client/src/main/java/org/apache/celeborn/client/read/checkpoint/WorkerPartitionReaderCheckpointMetadata.java:
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.celeborn.client.read.checkpoint;
+
+import java.util.Set;
+
+/** Checkpoint metadata for a partition reader on the worker side. */
+public class WorkerPartitionReaderCheckpointMetadata implements
PartitionReaderCheckpointMetadata {
Review Comment:
This class can be used in worker partition readers, DFS partition reader,
and local partition readers. IMO, here is no need to extract an empty interface
for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
