FMX commented on code in PR #3132:
URL: https://github.com/apache/celeborn/pull/3132#discussion_r1988615146
##########
client/src/main/java/org/apache/celeborn/client/read/DfsPartitionReader.java:
##########
@@ -308,4 +310,15 @@ private void closeStream() {
public PartitionLocation getLocation() {
return location;
}
+
+ @Override
+ public Optional<PartitionReaderCheckpointMetadata>
getPartitionReaderCheckpointMetadata() {
+ // TODO implement similar to {@link WorkerPartitionReader}
Review Comment:
That implementation is helpful for all partition readers. Why should we
leave the implementation as a to-do here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
