SteNicholas commented on code in PR #3360:
URL: https://github.com/apache/celeborn/pull/3360#discussion_r2336595869
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -4073,6 +4075,22 @@ object CelebornConf extends Logging {
.intConf
.createWithDefault(3)
+ val WORKER_WRITER_CREATE_INDEX_OR_SUCCESS_MAX_ATTEMPTS: ConfigEntry[Int] =
+ buildConf("celeborn.worker.writer.create.indexOrSuccess.maxAttempts")
Review Comment:
```suggestion
buildConf("celeborn.worker.writer.create.file.maxAttempts")
```
It's better to use `file` instead of `indexOrSuccess`.
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -4073,6 +4075,22 @@ object CelebornConf extends Logging {
.intConf
.createWithDefault(3)
+ val WORKER_WRITER_CREATE_INDEX_OR_SUCCESS_MAX_ATTEMPTS: ConfigEntry[Int] =
+ buildConf("celeborn.worker.writer.create.indexOrSuccess.maxAttempts")
+ .categories("worker")
+ .version("0.7.0")
+ .doc("Retry count for a index file writer to create if its creation was
failed.")
+ .intConf
+ .createWithDefault(5)
+
+ val WORKER_WRITER_CREATE_INDEX_OR_SUCCESS_WAIT_INTERVAL: ConfigEntry[Long] =
+ buildConf("celeborn.worker.writer.create.indexOrSuccess.wait.interval")
Review Comment:
Ditto.
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -4073,6 +4075,22 @@ object CelebornConf extends Logging {
.intConf
.createWithDefault(3)
+ val WORKER_WRITER_CREATE_INDEX_OR_SUCCESS_MAX_ATTEMPTS: ConfigEntry[Int] =
+ buildConf("celeborn.worker.writer.create.indexOrSuccess.maxAttempts")
+ .categories("worker")
+ .version("0.7.0")
+ .doc("Retry count for a index file writer to create if its creation was
failed.")
+ .intConf
+ .createWithDefault(5)
+
+ val WORKER_WRITER_CREATE_INDEX_OR_SUCCESS_WAIT_INTERVAL: ConfigEntry[Long] =
+ buildConf("celeborn.worker.writer.create.indexOrSuccess.wait.interval")
+ .categories("worker")
+ .version("0.7.0")
+ .doc("Wait interval after attempt to create index file or success file
and then retry it.")
+ .timeConf(TimeUnit.MILLISECONDS)
+ .createWithDefaultString("100ms")
Review Comment:
Why is the default value of wait interval 100ms? Any production practice
value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
