SteNicholas commented on code in PR #3360:
URL: https://github.com/apache/celeborn/pull/3360#discussion_r2347199178


##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -4073,6 +4075,22 @@ object CelebornConf extends Logging {
       .intConf
       .createWithDefault(3)
 
+  val WORKER_WRITER_CREATE_FILE_MAX_ATTEMPTS: ConfigEntry[Int] =
+    buildConf("celeborn.worker.writer.create.file.maxAttempts")

Review Comment:
   ```suggestion
       buildConf("celeborn.worker.writer.hdfs.createFile.maxRetries")
   ```



##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -1367,6 +1367,8 @@ class CelebornConf(loadDefaults: Boolean) extends 
Cloneable with Logging with Se
   def workerS3FlusherThreads: Int = get(WORKER_FLUSHER_S3_THREADS)
   def workerOssFlusherThreads: Int = get(WORKER_FLUSHER_OSS_THREADS)
   def workerCreateWriterMaxAttempts: Int = 
get(WORKER_WRITER_CREATE_MAX_ATTEMPTS)
+  def workerCreateIndexOrSuccessMaxAttempts: Int = 
get(WORKER_WRITER_CREATE_FILE_MAX_ATTEMPTS)

Review Comment:
   ```suggestion
     def workerCreateFileMaxAttempts: Int = 
get(WORKER_WRITER_CREATE_FILE_MAX_ATTEMPTS)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to