SteNicholas commented on code in PR #3360:
URL: https://github.com/apache/celeborn/pull/3360#discussion_r2350497978
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -1367,6 +1367,8 @@ class CelebornConf(loadDefaults: Boolean) extends
Cloneable with Logging with Se
def workerS3FlusherThreads: Int = get(WORKER_FLUSHER_S3_THREADS)
def workerOssFlusherThreads: Int = get(WORKER_FLUSHER_OSS_THREADS)
def workerCreateWriterMaxAttempts: Int =
get(WORKER_WRITER_CREATE_MAX_ATTEMPTS)
+ def workerWriterHDFSCreateFileMaxRetries: Int =
get(WORKER_WRITER_HDFS_CREATE_FILE_MAX_RETRIES)
+ def workerWriterHDFSCreateFileRetryWait: Long =
get(WORKER_WRITER_HDFS_CREATE_FILE_RETRY_WAIT)
Review Comment:
Ditto.
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -1367,6 +1367,8 @@ class CelebornConf(loadDefaults: Boolean) extends
Cloneable with Logging with Se
def workerS3FlusherThreads: Int = get(WORKER_FLUSHER_S3_THREADS)
def workerOssFlusherThreads: Int = get(WORKER_FLUSHER_OSS_THREADS)
def workerCreateWriterMaxAttempts: Int =
get(WORKER_WRITER_CREATE_MAX_ATTEMPTS)
+ def workerWriterHDFSCreateFileMaxRetries: Int =
get(WORKER_WRITER_HDFS_CREATE_FILE_MAX_RETRIES)
Review Comment:
```suggestion
def workerWriterHdfsCreateFileMaxRetries: Int =
get(WORKER_WRITER_HDFS_CREATE_FILE_MAX_RETRIES)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]