SteNicholas commented on code in PR #3360:
URL: https://github.com/apache/celeborn/pull/3360#discussion_r2347199178
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -4073,6 +4075,22 @@ object CelebornConf extends Logging {
.intConf
.createWithDefault(3)
+ val WORKER_WRITER_CREATE_FILE_MAX_ATTEMPTS: ConfigEntry[Int] =
+ buildConf("celeborn.worker.writer.create.file.maxAttempts")
Review Comment:
```suggestion
buildConf("celeborn.worker.writer.hdfs.createFile.maxRetries")
```
Please update the description and corresponding method name of this config.
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -4073,6 +4075,22 @@ object CelebornConf extends Logging {
.intConf
.createWithDefault(3)
+ val WORKER_WRITER_CREATE_FILE_MAX_ATTEMPTS: ConfigEntry[Int] =
+ buildConf("celeborn.worker.writer.create.file.maxAttempts")
+ .categories("worker")
+ .version("0.7.0")
+ .doc("Retry count for a index file writer to create if its creation was
failed.")
+ .intConf
+ .createWithDefault(5)
+
+ val WORKER_WRITER_CREATE_FILE_WAIT_INTERVAL: ConfigEntry[Long] =
+ buildConf("celeborn.worker.writer.create.file.wait.interval")
Review Comment:
```suggestion
buildConf("celeborn.worker.writer.hdfs.createFile.retryWait")
```
Please update the description and corresponding method name of this config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
