[
https://issues.apache.org/jira/browse/CLOUDSTACK-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15242015#comment-15242015
]
ASF GitHub Bot commented on CLOUDSTACK-8562:
--------------------------------------------
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59800096
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java ---
@@ -117,6 +123,12 @@ public long getEntityOwnerId() {
@Override
public void execute() {
+ if (Strings.isNullOrEmpty(getCfgName())) {
+ throw new ServerApiException(ApiErrorCode.PARAM_ERROR, "Empty
configuration name provided");
+ }
+ if
(getCfgName().equalsIgnoreCase(RoleService.EnableDynamicApiChecker.key())) {
+ throw new ServerApiException(ApiErrorCode.METHOD_NOT_ALLOWED,
"Restricted configuration update not allowed");
--- End diff --
Method Not Allowed (405) indicates the caller attempted to use an HTTP
method (i.e. GET, PUT, POST, DELETE) that is not allowed for the resource. In
this case, the method is allowed, but the parameters do not all the method to
be performed. Seems like ``PARAM_ERROR`` would be more appropriate.
> User Definable Roles
> --------------------
>
> Key: CLOUDSTACK-8562
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8562
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Reporter: Paul Angus
> Assignee: Rohit Yadav
>
> Static command.properties moved to database and made user definable
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
