[ https://issues.apache.org/jira/browse/CLOUDSTACK-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15242034#comment-15242034 ]
ASF GitHub Bot commented on CLOUDSTACK-8562: -------------------------------------------- Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59801226 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade481to490.java --- @@ -53,6 +62,139 @@ public boolean supportsRollingUpgrade() { @Override public void performDataMigration(Connection conn) { + setupRolesAndPermissionsForDynamicRBAC(conn); + } + + private void createDefaultRole(final Connection conn, final Long id, final String name, final RoleType roleType) { + final String insertSql = String.format("INSERT INTO `cloud`.`roles` (`id`, `uuid`, `name`, `role_type`, `description`) values (%d, UUID(), '%s', '%s', 'Default %s role');", + id, name, roleType.name(), roleType.name().toLowerCase()); + try ( PreparedStatement updatePstmt = conn.prepareStatement(insertSql) ) { + updatePstmt.executeUpdate(); + } catch (SQLException e) { + throw new CloudRuntimeException("Unable to create default role with id: " + id + " name: " + name, e); + } + } + + private void createRoleMapping(final Connection conn, final Long roleId, final String apiName) { + final String insertSql = String.format("INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, `rule`, `permission`) values (UUID(), %d, '%s', 'ALLOW') ON DUPLICATE KEY UPDATE rule=rule;", + roleId, apiName); + try ( PreparedStatement updatePstmt = conn.prepareStatement(insertSql)) { + updatePstmt.executeUpdate(); + } catch (SQLException ignored) { + s_logger.debug("Unable to insert mapping for role id:" + roleId + " apiName: " + apiName); --- End diff -- Why not log this condition to ``WARN``? > User Definable Roles > -------------------- > > Key: CLOUDSTACK-8562 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8562 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server > Reporter: Paul Angus > Assignee: Rohit Yadav > > Static command.properties moved to database and made user definable -- This message was sent by Atlassian JIRA (v6.3.4#6332)