[
https://issues.apache.org/jira/browse/CLOUDSTACK-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15242025#comment-15242025
]
ASF GitHub Bot commented on CLOUDSTACK-8562:
--------------------------------------------
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59800553
--- Diff: api/test/org/apache/cloudstack/acl/RoleTypeTest.java ---
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.acl;
+
+import com.cloud.user.Account;
+import org.junit.Assert;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+import java.util.Arrays;
+
+public class RoleTypeTest {
+
+ @Test
+ public void testRoleTypeFromString() {
+ Assert.assertEquals(RoleType.fromString(null), null);
+ Assert.assertEquals(RoleType.fromString(""), null);
+ Assert.assertEquals(RoleType.fromString("admin"), null);
+ Assert.assertEquals(RoleType.fromString("12345%^&*"), null);
+ for (RoleType roleType : RoleType.values()) {
+ Assert.assertEquals(RoleType.fromString(roleType.name()),
roleType);
+ }
+ }
+
+ @Test
+ public void testDefaultRoleMaskByValue() {
+ Assert.assertEquals(RoleType.fromMask(1), RoleType.Admin);
+ Assert.assertEquals(RoleType.fromMask(2), RoleType.ResourceAdmin);
+ Assert.assertEquals(RoleType.fromMask(4), RoleType.DomainAdmin);
+ Assert.assertEquals(RoleType.fromMask(8), RoleType.User);
+ Assert.assertEquals(RoleType.fromMask(0), RoleType.Unknown);
--- End diff --
What happens if ``fromMask`` is passed unexpected integer values?
> User Definable Roles
> --------------------
>
> Key: CLOUDSTACK-8562
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8562
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Reporter: Paul Angus
> Assignee: Rohit Yadav
>
> Static command.properties moved to database and made user definable
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
