[ https://issues.apache.org/jira/browse/CLOUDSTACK-9698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15787090#comment-15787090 ]
ASF GitHub Bot commented on CLOUDSTACK-9698: -------------------------------------------- Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1861#discussion_r94206888 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -839,7 +840,12 @@ private int findRouterEthDeviceIndex(String domrName, String routerIp, String ma // when we dynamically plug in a new NIC into virtual router, it may take time to show up in guest OS // we use a waiting loop here as a workaround to synchronize activities in systems long startTick = System.currentTimeMillis(); - while (System.currentTimeMillis() - startTick < 15000) { + long waitTimeoutMillis = 15000; + Long waitTimeoutMillisLong = VmwareManagerImpl.s_vmwareNicHotplugWaitTimeout.value(); + if (waitTimeoutMillisLong != null) { + waitTimeoutMillis = waitTimeoutMillisLong; + } + while (System.currentTimeMillis() - startTick < waitTimeoutMillis) { --- End diff -- The config value can be directly read using s_vmwareNicHotplugWaitTimeout.value(), no need for the checks. > Make the wait timeout for NIC adapter hotplug as configurable > ------------------------------------------------------------- > > Key: CLOUDSTACK-9698 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9698 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: VMware > Affects Versions: 4.9.0.1 > Environment: ACS 4.9 branch commit > a0e36b73aebe43bfe6bec3ef8f53e8cb99ecbc32 > vSphere 5.5 > Reporter: Sateesh Chodapuneedi > Assignee: Sateesh Chodapuneedi > Fix For: 4.9.1.0 > > > Currently ACS waits for 15 seconds (*hard coded*) for hot-plugged NIC in VR > to get detected by guest OS. The time taken to detect hot plugged NIC in > guest OS depends on type of NIC adapter like (E1000, VMXNET3, E1000e etc.) > and guest OS itself. In uncommon scenarios the NIC detection may take longer > time than 15 seconds, in such cases NIC hotplug would be treated as failure > which results in VPC tier configuration failure. Making the wait timeout for > NIC adapter hotplug as configurable will be helpful for admins in such > scenarios. > Also in future if VMware introduces new NIC adapter types which may take time > to get detected by guest OS, it is good to have flexibility of configuring > the wait timeout. -- This message was sent by Atlassian JIRA (v6.3.4#6332)