[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15787088#comment-15787088
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9698:
--------------------------------------------

Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1861#discussion_r94206618
  
    --- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
    @@ -230,6 +230,7 @@
     import com.cloud.hypervisor.guru.VMwareGuru;
     import com.cloud.hypervisor.vmware.manager.VmwareHostService;
     import com.cloud.hypervisor.vmware.manager.VmwareManager;
    +import com.cloud.hypervisor.vmware.manager.VmwareManagerImpl;
    --- End diff --
    
    Better to define the config parameter in VmwareManager itself.


> Make the wait timeout for NIC adapter hotplug as configurable
> -------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9698
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9698
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: VMware
>    Affects Versions: 4.9.0.1
>         Environment: ACS 4.9 branch commit 
> a0e36b73aebe43bfe6bec3ef8f53e8cb99ecbc32
> vSphere 5.5
>            Reporter: Sateesh Chodapuneedi
>            Assignee: Sateesh Chodapuneedi
>             Fix For: 4.9.1.0
>
>
> Currently ACS waits for 15 seconds (*hard coded*) for hot-plugged NIC in VR 
> to get detected by guest OS. The time taken to detect hot plugged NIC in 
> guest OS depends on type of NIC adapter like (E1000, VMXNET3, E1000e etc.) 
> and guest OS itself. In uncommon scenarios the NIC detection may take longer 
> time than 15 seconds, in such cases NIC hotplug would be treated as failure 
> which results in VPC tier configuration failure. Making the wait timeout for 
> NIC adapter hotplug as configurable will be helpful for admins in such 
> scenarios. 
> Also in future if VMware introduces new NIC adapter types which may take time 
> to get detected by guest OS, it is good to have flexibility of configuring 
> the wait timeout.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to