ali-ghanbari commented on pull request #233: URL: https://github.com/apache/commons-text/pull/233#issuecomment-886257991
Thank you @kinow for mentioning the CI issue. It looks like that the issue is due to a recent change([see](https://github.com/apache/commons-text/commit/87640ed259da32f6af516b9b638ae46d96c9ff24) for the update that resolves the CI errors) in CI configuration which makes the older version of `StrTokenizer.java` (which contains several dangling `p` tags in its Javadocs) to fail checkstyle checks. I guess the issue can be ignored for the time being? Please let me know if we should update `StrTokenizer.java` according to the latest version. Please also see the newest version of the implementation which avoids checkstyle warnings by passing the arguments to `algorithmB` using instance fields (it used to complain because we had methods with more than 7 parameters). With this change it is imperative to have _separate instances_ of the class in case if we want to run the algorithm concurrently. By the way, I managed to run JMH. Please check out the Javadoc for `apply` method to see the results. Thank you again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
