ali-ghanbari commented on pull request #233: URL: https://github.com/apache/commons-text/pull/233#issuecomment-886430226
Hello, Thank you @kinow for the insightful comment regarding `StringBuilder` object used in `algorithmC`. It took me a while to understand that it is possible to allocate the object outside of the method, but I finally managed to code it! I think `algorithmC` is now satisfying all the assumptions made by the paper and a back of the envelope calculation will reveal that the method has indeed linear space complexity. I have made a whole bunch of refactoring and added lots of comments and Javadoc to improve readability of the code. I have also deleted the method logestCommonSubsequence for you (the one that had typo in its name and it was planned to be removed in version 2.0). From now on, unless the reviewers request some changes, I am unlikely to make updates to the class. So, I would say, it is safe to review :) I will add the code for JMH as soon as I find some spare time. Thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
