garydgregory commented on code in PR #1328:
URL: https://github.com/apache/commons-lang/pull/1328#discussion_r1872030406
##########
src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java:
##########
@@ -229,21 +230,33 @@ public void assertReflectionArray(final String expected,
final Object actual) {
*/
@Test
public void test_setUpToClass_invalid() {
- final Integer val = Integer.valueOf(5);
+ final HirAFixture val = new HirAFixture();
final ReflectionToStringBuilder test = new
ReflectionToStringBuilder(val);
assertThrows(IllegalArgumentException.class, () ->
test.setUpToClass(String.class));
test.toString();
}
+ private static class HirAFixture extends HirBFixture {
+ int x = 1;
+ }
+
+ private static class HirBFixture extends HirCFixture {
+ int y = 2;
+ }
+
+ private static class HirCFixture {
Review Comment:
That's not what I'm saying ;-) What I'm trying to say is that the check
_cannot_ use _any_ interfaces. It doesn't matter that the _builds_ needs JPMS
opens, what matters is how many hoops we want to jump through for the _runtime_
to avoid opens, and for that, I claim we can only check for classes, never
interfaces. The fact that the build uses opens makes it obvious to users that
they'll need them as well at runtime. Presumably, depending on the app, this is
something that would show up in the app's unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
