struberg commented on PR #1328: URL: https://github.com/apache/commons-lang/pull/1328#issuecomment-2523121335
> You cannot check for interfaces to short-circuit logic in `Reflection.isJavaInternalClass()`. This will break existing applications. Which of those is an interface? https://github.com/struberg/commons-lang/blob/ec4150bc13cfd2705e5d672f47706930af578c39/src/main/java/org/apache/commons/lang3/builder/Reflection.java#L62 The thing you are talking about IS ALREADY RESOLVED since yesterday. And one other thing: commons-lang3 ReflectionToString ReflectionEquals etc was BROKEN on anything Java9++ - period! The build is ONLY green because you just disabled all the modularity - which is something not everyone can do in real projects! My spare time to work on this stuff is very limited - as is yours I bet. So please use our both time productively. As I said: not everything will fully work from the beginning. You just added `java.time.Period`, fine, good catch. But why on earth don't we just take that PR and commit it and then improve it TOGETHER? I'm not willing to do more empty rounds getting sticks thrown at me at will. I really appreciate the review feedback as it indeed did highly improve the code. But now is the point to decide whether the direction is right or not - and then improve things from here TOGETHER. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
