ppkarwasz commented on code in PR #710:
URL: https://github.com/apache/commons-compress/pull/710#discussion_r2378348374


##########
src/main/java/org/apache/commons/compress/archivers/dump/DumpArchiveInputStream.java:
##########
@@ -547,7 +550,8 @@ private void readDirectoryEntry(DumpArchiveEntry entry) 
throws IOException {
 
                 final byte type = blockBuffer[i + 6];
 
-                final String name = DumpArchiveUtil.decode(zipEncoding, 
blockBuffer, i + 8, blockBuffer[i + 7]);
+                final String name =
+                        DumpArchiveUtil.decode(zipEncoding, blockBuffer, i + 
8, Byte.toUnsignedInt(blockBuffer[i + 7]));

Review Comment:
   This change fixes an unrelated type conversion problem. I created a separate 
PR #711 for this, but I need the fix for the unit tests to succeed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to