ppkarwasz commented on code in PR #710:
URL: https://github.com/apache/commons-compress/pull/710#discussion_r2379997213
##########
src/main/java/org/apache/commons/compress/archivers/tar/TarFile.java:
##########
@@ -507,7 +511,14 @@ private TarArchiveEntry getNextTarEntry() throws
IOException {
lastWasSpecial = TarUtils.isSpecialTarRecord(currEntry);
if (lastWasSpecial) {
// Handle PAX, GNU long name, or other special records
- TarUtils.handleSpecialTarRecord(getInputStream(currEntry),
zipEncoding, currEntry, paxHeaders, sparseHeaders, globalPaxHeaders,
Review Comment:
I realize this bothers you, so I’ve been correcting it whenever I noticed
line breaks you don’t like.
As I mentioned earlier, the root cause is that we’re not using the same
editors or sharing a common configuration. IntelliJ IDEA and Eclipse apply
different formatting rules, and even after setting IDEA’s right margin to 160
characters I noticed that it sometimes still exceeded the limit until I tweaked
additional options.
In
https://github.com/apache/commons-compress/pull/710/commits/94c8f6ee0ce2999015b540f548414a85779b691b
I adjusted the style to be closer to what you expect. That said, until we
adopt a **deterministic formatter** (one that rewrites line breaks consistently
and leaves only blank lines to user choice), we’ll continue to run into these
inconsistencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
