ppkarwasz commented on code in PR #710:
URL: https://github.com/apache/commons-compress/pull/710#discussion_r2378667177
##########
src/test/java/org/apache/commons/compress/archivers/cpio/CpioArchiveInputStreamTest.java:
##########
@@ -90,33 +89,6 @@ void testCpioUnarchiveMultibyteCharName() throws Exception {
assertEquals(2, count);
}
- @Test
- void testEndOfFileInEntry_c_namesize_0x7FFFFFFF() throws Exception {
- // CPIO header with c_namesize = 0x7FFFFFFF
Review Comment:
A similar test it now included in `MaxNameEntryLengthTest`, but with improve
semantics: a size of `0x7FFF_FFFF` will never work, due to the limitation on
Java arrays and `MemoryLimitException` will always be thrown.
The new test case instead, lowers the size to `0x7FFF_FFF7` and adapts its
expectation depending on whether the system has 2 GiB of memory available
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
