garydgregory commented on code in PR #469:
URL: https://github.com/apache/commons-bcel/pull/469#discussion_r2394842851
##########
src/test/java/org/apache/bcel/classfile/ConstantPoolModuleAccessTest.java:
##########
@@ -161,7 +161,7 @@ public void visitModule(final Module obj) {
expected.add("java.time.chrono.AbstractChronology");
expected.add("java.time.chrono.Chronology");
expected.add("java.time.zone.ZoneRulesProvider");
- if (javaClass.getMajor() > Const.MAJOR_11) {
+ if (javaClass.getMajor() > Const.MAJOR_11 &&
javaClass.getMajor() < Const.MAJOR_24) {
Review Comment:
Hello @iloveeclipse
Thank you for your update. How are you checking `module-info.class` outside
this test? The runtime might have a bug after all.
Please help me understand why I see the package exported but not visible in
the test:
```
> jmod describe
/opt/homebrew/Cellar/openjdk/25/libexec/openjdk.jdk/Contents/Home/jmods/java.base.jmod
| grep 'java.util.random'
exports java.util.random
```
and
```
> jmod list
/opt/homebrew/Cellar/openjdk/25/libexec/openjdk.jdk/Contents/Home/jmods/java.base.jmod
| grep 'java.util.random'
classes/java/util/random/RandomGenerator$ArbitrarilyJumpableGenerator.class
classes/java/util/random/RandomGenerator$JumpableGenerator.class
classes/java/util/random/RandomGenerator$LeapableGenerator.class
classes/java/util/random/RandomGenerator$SplittableGenerator.class
classes/java/util/random/RandomGenerator$StreamableGenerator.class
classes/java/util/random/RandomGenerator.class
classes/java/util/random/RandomGeneratorFactory$RandomGeneratorProperties.class
classes/java/util/random/RandomGeneratorFactory.class
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
