iloveeclipse commented on code in PR #469:
URL: https://github.com/apache/commons-bcel/pull/469#discussion_r2394927514
##########
src/test/java/org/apache/bcel/classfile/ConstantPoolModuleAccessTest.java:
##########
@@ -161,7 +161,7 @@ public void visitModule(final Module obj) {
expected.add("java.time.chrono.AbstractChronology");
expected.add("java.time.chrono.Chronology");
expected.add("java.time.zone.ZoneRulesProvider");
- if (javaClass.getMajor() > Const.MAJOR_11) {
+ if (javaClass.getMajor() > Const.MAJOR_11 &&
javaClass.getMajor() < Const.MAJOR_24) {
Review Comment:
You have to expand "JRE System Library" node in Packages Explorer, go to the
desired module,
<img width="470" height="78" alt="image"
src="https://github.com/user-attachments/assets/88723837-c8b5-4c1e-9ada-d042e0a01fdd";
/>
expand it, scroll down to the module-info.class
<img width="470" height="78" alt="image"
src="https://github.com/user-attachments/assets/2d482e45-00f6-41a0-a552-56dfeb74a511";
/>
and either open this in the editor or select same module-info.class from
another JDK and say "Compare with each other Bytecode".
In both cases you will see some kind of disassembled code which is not same
as javap would show, but it shows enough to see the difference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
