iloveeclipse commented on code in PR #469:
URL: https://github.com/apache/commons-bcel/pull/469#discussion_r2394734876
##########
src/test/java/org/apache/bcel/classfile/ConstantPoolModuleAccessTest.java:
##########
@@ -161,7 +161,7 @@ public void visitModule(final Module obj) {
expected.add("java.time.chrono.AbstractChronology");
expected.add("java.time.chrono.Chronology");
expected.add("java.time.zone.ZoneRulesProvider");
- if (javaClass.getMajor() > Const.MAJOR_11) {
+ if (javaClass.getMajor() > Const.MAJOR_11 &&
javaClass.getMajor() < Const.MAJOR_24) {
Review Comment:
The test checks the content of `module-info.class`, not the content of the
packages in JDK. The `module-info.class` has now no reference to the mentioned
classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
