[
https://issues.apache.org/jira/browse/GEOMETRY-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937269#comment-16937269
]
Matt Juntunen commented on GEOMETRY-46:
---------------------------------------
I added some small comments in github on the PR related to style.
Unfortunately, our github build is broken on jdk 13+ so we don't get a green
light on it. [~erans], are you okay with merging anyway?
> Additional UnitVector methods
> -----------------------------
>
> Key: GEOMETRY-46
> URL: https://issues.apache.org/jira/browse/GEOMETRY-46
> Project: Apache Commons Geometry
> Issue Type: Improvement
> Reporter: Matt Juntunen
> Priority: Minor
> Labels: easyfix, pull-request-available, starter
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The following methods should be overridden in the {{UnitVector}} private
> subclasses of the {{Vector?D}} classes:
> * {{normSq}} -- should return {{1}} for consistency with {{norm}}
> * {{negate}} -- should be overridden to also return a {{UnitVector}} instance
> instead of a regular {{Vector?D}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
