[
https://issues.apache.org/jira/browse/GEOMETRY-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937584#comment-16937584
]
Gilles commented on GEOMETRY-46:
--------------------------------
Surprised by this use of {{super}}, I couldn't find any link on the web about
this access to private _instance_ fields (from a _static_ nested class); yet it
works...
However, while looking at that, it occurred to me that there could be some
improvement around the "normalize" functionality. Please comment on the patch
which I've just attached (diff is against PR #39, not master).
> Additional UnitVector methods
> -----------------------------
>
> Key: GEOMETRY-46
> URL: https://issues.apache.org/jira/browse/GEOMETRY-46
> Project: Apache Commons Geometry
> Issue Type: Improvement
> Reporter: Matt Juntunen
> Priority: Minor
> Labels: easyfix, pull-request-available, starter
> Attachments: GEOMETRY-46.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The following methods should be overridden in the {{UnitVector}} private
> subclasses of the {{Vector?D}} classes:
> * {{normSq}} -- should return {{1}} for consistency with {{norm}}
> * {{negate}} -- should be overridden to also return a {{UnitVector}} instance
> instead of a regular {{Vector?D}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
