[ https://issues.apache.org/jira/browse/GEOMETRY-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937556#comment-16937556 ]
Gilles commented on GEOMETRY-46: -------------------------------- In the unit tests, the tolerance should be set to 0 (since the purpose of that specialized class is to return exactly 1 for the norm). Nit-pick: Spurious (trailing) white-space characters. > Additional UnitVector methods > ----------------------------- > > Key: GEOMETRY-46 > URL: https://issues.apache.org/jira/browse/GEOMETRY-46 > Project: Apache Commons Geometry > Issue Type: Improvement > Reporter: Matt Juntunen > Priority: Minor > Labels: easyfix, pull-request-available, starter > Time Spent: 10m > Remaining Estimate: 0h > > The following methods should be overridden in theĀ {{UnitVector}} private > subclasses of the {{Vector?D}} classes: > * {{normSq}} -- should return {{1}} for consistency with {{norm}} > * {{negate}} -- should be overridden to also return a {{UnitVector}} instance > instead of a regular {{Vector?D}} -- This message was sent by Atlassian Jira (v8.3.4#803005)