[ https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16996909#comment-16996909 ]
Gilles Sadowski commented on COLLECTIONS-728: --------------------------------------------- {quote}I would like to avoid that discussion until the core components are in place. {quote} >From the outset, I have been trying to minimize discussion by suggesting just >that: Limiting the initial commit to the core functionality. If I'm not >mistaken, this is what lead to moving hash implementations from here to >[Codec], among other simplifications of the code. {quote}should not try to implement all hash functions [...] {quote} OK; let's assume that. {quote}provide a framework that identifies when the hash functions are not the same {quote} OK, but what is the simplest way to do that? IMHO, as we cannot hope that the {{HashFunction}} becomes a "standard", we should keep it as simple as possible for application developers. I.e. maybe just make it a "marker" interface (?). Would it be sufficient to have the Javadoc saying that applications using this (Bloom filter) functionality must define an {{equals(Object)}} method whose purpose is to identify when two {{HashFunction}} instances can be considered the same or not? > BloomFilter contribution > ------------------------ > > Key: COLLECTIONS-728 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-728 > Project: Commons Collections > Issue Type: Task > Reporter: Claude Warren > Priority: Minor > Attachments: BF_Func.md, BloomFilter.java, BloomFilterI2.java, > Usage.md > > > Contribution of BloomFilter library comprising base implementation and gated > collections. -- This message was sent by Atlassian Jira (v8.3.4#803005)