[ 
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17002067#comment-17002067
 ] 

Gilles Sadowski commented on COLLECTIONS-728:
---------------------------------------------

bq. how do you propose to move the hash function [...]

In the code which you propose for inclusion in [Collections], nothing requires 
serialization (hence the reluctance to impose {{Serializable}}).  If some 
application requires serialization, it must create an instance of 
{{HashFunction}} that can be serialized.

bq.  What do you mean by "external code"

You referred to "CachingHasher (from another project)": Another project != this 
project.
"CachingHasher" is not part of this code base, yet it dictates an API.  I'd be 
more comfortable starting with an internally consistent and minimal API.  Then 
if a use case comes up (like "CachingHasher"), requests for enhancement can be 
considered.

bq. The isIterative() question is information about how the hash is constructed

In my (possibly short-sighted) view, [Collections] is the not the place to 
define an API for describing hash functions.

Would those methods that describe hash function's properties be called from 
inside this code?

> BloomFilter contribution
> ------------------------
>
>                 Key: COLLECTIONS-728
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-728
>             Project: Commons Collections
>          Issue Type: Task
>            Reporter: Claude Warren
>            Priority: Minor
>         Attachments: BF_Func.md, BloomFilter.java, BloomFilterI2.java, 
> Usage.md
>
>
> Contribution of BloomFilter library comprising base implementation and gated 
> collections.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to