[ 
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003589#comment-17003589
 ] 

Claude Warren commented on COLLECTIONS-728:
-------------------------------------------

I  think we may have to agree to disagree on this one.

I can think of no way to compare hash function properties and only a 
same/not-same comparison possible using the equals() method.  Given that there 
might be 2 implementations that yield identical results this is not an optimal 
solution.  The decomposition of the properties into an interface makes it 
possible to identify such.

Caching hasher is not part of this code base yet it builds upon it.  It was 
built on the opportunity created by this code base as a natural upshot of being 
able to identify the properties of the hash function.  If you wish I will 
contribute CachingHasher as part of this code.
{quote}Would those methods that describe hash function's properties be called 
from inside this code?
{quote}
They already are using inside this code.  It is part of determining if a Shape 
is the same for different filters.

 

 

> BloomFilter contribution
> ------------------------
>
>                 Key: COLLECTIONS-728
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-728
>             Project: Commons Collections
>          Issue Type: Task
>            Reporter: Claude Warren
>            Priority: Minor
>         Attachments: BF_Func.md, BloomFilter.java, BloomFilterI2.java, 
> Usage.md
>
>
> Contribution of BloomFilter library comprising base implementation and gated 
> collections.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to