[
https://issues.apache.org/jira/browse/CB-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539504#comment-16539504
]
ASF GitHub Bot commented on CB-14201:
-------------------------------------
erisu opened a new pull request #465: CB-14201: (android) Removes Gradle
property in-line command arguments…
URL: https://github.com/apache/cordova-android/pull/465
### Platforms affected
Android
### What does this PR do?
This PR removes the Gradle properties in-line command arguments in favor of
setting the gradle.properties file.
This PR will give users more flexibility to override defaults that Cordova
defines.
### What testing has been done on this change?
- Locally ran the unit test, eslint, and code coverage.
- Locally ran the Cordova prepare, run and build commands.
- https://travis-ci.org/erisu/cordova-android/builds/402490984
- https://ci.appveyor.com/project/erisu/cordova-android/build/1.0.41
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove Gradle property in-line command arguments for gradle.properties
> ----------------------------------------------------------------------
>
> Key: CB-14201
> URL: https://issues.apache.org/jira/browse/CB-14201
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Reporter: Bryan Ellis
> Priority: Minor
>
> By passing in properties as an argument to the Gradle's command, it prevents
> users from being able to override these values.
> In one example, a user reported
> ([CB-14139|https://issues.apache.org/jira/browse/CB-14139]) the need to be
> able to set the jvmargs so builds works on 32bit Java.
> Some other values Cordova passes by default are org.gradle.daemon and
> android.useDeprecatedNdk.
> By removing the command line argument usage and migrating to the usage of
> gradle.properties, it gives users the flexibility to override defaults if
> desired.
> This ticket will also resolve
> [CB-14139|https://issues.apache.org/jira/browse/CB-14139] but also remove the
> other argument usage.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
