[ https://issues.apache.org/jira/browse/CB-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540035#comment-16540035 ]
ASF GitHub Bot commented on CB-14201: ------------------------------------- janpio commented on issue #465: CB-14201: (android) Removes Gradle property in-line command arguments… URL: https://github.com/apache/cordova-android/pull/465#issuecomment-404155186 Did I get this right: You removed the previous harcoded default configs and created a `gradle.properties` parser that uses the old defaults to create the file if it is missing. Correct? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove Gradle property in-line command arguments for gradle.properties > ---------------------------------------------------------------------- > > Key: CB-14201 > URL: https://issues.apache.org/jira/browse/CB-14201 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android > Reporter: Bryan Ellis > Priority: Minor > > By passing in properties as an argument to the Gradle's command, it prevents > users from being able to override these values. > In one example, a user reported > ([CB-14139|https://issues.apache.org/jira/browse/CB-14139]) the need to be > able to set the jvmargs so builds works on 32bit Java. > Some other values Cordova passes by default are org.gradle.daemon and > android.useDeprecatedNdk. > By removing the command line argument usage and migrating to the usage of > gradle.properties, it gives users the flexibility to override defaults if > desired. > This ticket will also resolve > [CB-14139|https://issues.apache.org/jira/browse/CB-14139] but also remove the > other argument usage. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org