[
https://issues.apache.org/jira/browse/CB-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539530#comment-16539530
]
ASF GitHub Bot commented on CB-14201:
-------------------------------------
codecov-io edited a comment on issue #465: CB-14201: (android) Removes Gradle
property in-line command arguments…
URL: https://github.com/apache/cordova-android/pull/465#issuecomment-404037636
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/465?src=pr&el=h1)
Report
> Merging
[#465](https://codecov.io/gh/apache/cordova-android/pull/465?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/cordova-android/commit/b6e4598e7c35dba433a5309c3c633485585dc692?src=pr&el=desc)
will **increase** coverage by `0.47%`.
> The diff coverage is `82.75%`.
[](https://codecov.io/gh/apache/cordova-android/pull/465?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #465 +/- ##
==========================================
+ Coverage 60.56% 61.04% +0.47%
==========================================
Files 17 18 +1
Lines 1694 1720 +26
Branches 312 315 +3
==========================================
+ Hits 1026 1050 +24
- Misses 668 670 +2
```
| [Impacted
Files](https://codecov.io/gh/apache/cordova-android/pull/465?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/465/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz)
| `21.15% <ø> (+0.39%)` | :arrow_up: |
|
[...lates/cordova/lib/config/GradlePropertiesParser.js](https://codecov.io/gh/apache/cordova-android/pull/465/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jb25maWcvR3JhZGxlUHJvcGVydGllc1BhcnNlci5qcw==)
| `82.75% <82.75%> (ø)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-android/pull/465?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/465?src=pr&el=footer).
Last update
[b6e4598...c00d64d](https://codecov.io/gh/apache/cordova-android/pull/465?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove Gradle property in-line command arguments for gradle.properties
> ----------------------------------------------------------------------
>
> Key: CB-14201
> URL: https://issues.apache.org/jira/browse/CB-14201
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Reporter: Bryan Ellis
> Priority: Minor
>
> By passing in properties as an argument to the Gradle's command, it prevents
> users from being able to override these values.
> In one example, a user reported
> ([CB-14139|https://issues.apache.org/jira/browse/CB-14139]) the need to be
> able to set the jvmargs so builds works on 32bit Java.
> Some other values Cordova passes by default are org.gradle.daemon and
> android.useDeprecatedNdk.
> By removing the command line argument usage and migrating to the usage of
> gradle.properties, it gives users the flexibility to override defaults if
> desired.
> This ticket will also resolve
> [CB-14139|https://issues.apache.org/jira/browse/CB-14139] but also remove the
> other argument usage.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
