[ 
https://issues.apache.org/jira/browse/DRILL-4980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633401#comment-15633401
 ] 

ASF GitHub Bot commented on DRILL-4980:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/644#discussion_r86388085
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordWriter.java
 ---
    @@ -78,7 +78,7 @@
       private static final int MAXIMUM_RECORD_COUNT_FOR_CHECK = 10000;
     
       public static final String DRILL_VERSION_PROPERTY = "drill.version";
    -  public static final String IS_DATE_CORRECT_PROPERTY = "is.date.correct";
    +  public static final String WRITER_VERSION_PROPERTY = 
"parquet-writer.version";
    --- End diff --
    
    We know we are Drill, but others might be confused. Perhaps 
"drill-writer.version" or "drill.writer-version" (to be consistent with 
"drill.version".)


> Upgrading of the approach of parquet date correctness status detection
> ----------------------------------------------------------------------
>
>                 Key: DRILL-4980
>                 URL: https://issues.apache.org/jira/browse/DRILL-4980
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Storage - Parquet
>    Affects Versions: 1.8.0
>            Reporter: Vitalii Diravka
>            Assignee: Vitalii Diravka
>             Fix For: 1.9.0
>
>
> This jira is an addition for the 
> [DRILL-4203|https://issues.apache.org/jira/browse/DRILL-4203].
> The date correctness label for the new generated parquet files should be 
> upgraded. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to