[ 
https://issues.apache.org/jira/browse/DRILL-4980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15637390#comment-15637390
 ] 

ASF GitHub Bot commented on DRILL-4980:
---------------------------------------

Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/644#discussion_r86615126
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java 
---
    @@ -927,15 +927,11 @@ public void setMax(Object max) {
         @JsonProperty List<ParquetFileMetadata_v2> files;
         @JsonProperty List<String> directories;
         @JsonProperty String drillVersion;
    -    @JsonProperty boolean isDateCorrect;
    +    @JsonProperty int writerVersion;
    --- End diff --
    
    I tried to figure out this and found that for reading parquet footer this 
class isn't used. For that purposes used `ParquetMetadata` from 
parquet-hadoop-1.8.1-drill-r0.jar.
    This class used for entire parquet directory with metadata cache file. When 
it is absent an empty of this class is created. 
    I added some javadoc. Hope it will help.


> Upgrading of the approach of parquet date correctness status detection
> ----------------------------------------------------------------------
>
>                 Key: DRILL-4980
>                 URL: https://issues.apache.org/jira/browse/DRILL-4980
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Storage - Parquet
>    Affects Versions: 1.8.0
>            Reporter: Vitalii Diravka
>            Assignee: Vitalii Diravka
>             Fix For: 1.9.0
>
>
> This jira is an addition for the 
> [DRILL-4203|https://issues.apache.org/jira/browse/DRILL-4203].
> The date correctness label for the new generated parquet files should be 
> upgraded. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to