[
https://issues.apache.org/jira/browse/DRILL-4980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633406#comment-15633406
]
ASF GitHub Bot commented on DRILL-4980:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/644#discussion_r86388727
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetWriter.java
---
@@ -40,6 +40,8 @@
public class ParquetWriter extends AbstractWriter {
static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(ParquetWriter.class);
+ public static final int WRITER_VERSION = 2;
--- End diff --
This deserves an explanation. Something like:
Version of Drill's Parquet writer. Increment this version (by 1) any time
we make any format change to the file. Format changes include 1) supporting new
data types, 2) changes to the format of data fields, 3) adding new metadata to
the file footer, etc.
Newer readers must be able to read old files. The Writer version tells the
Parquet reader how to interpret fields or metadata when that data changes
format from one writer version to another.
> Upgrading of the approach of parquet date correctness status detection
> ----------------------------------------------------------------------
>
> Key: DRILL-4980
> URL: https://issues.apache.org/jira/browse/DRILL-4980
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Parquet
> Affects Versions: 1.8.0
> Reporter: Vitalii Diravka
> Assignee: Vitalii Diravka
> Fix For: 1.9.0
>
>
> This jira is an addition for the
> [DRILL-4203|https://issues.apache.org/jira/browse/DRILL-4203].
> The date correctness label for the new generated parquet files should be
> upgraded.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
