[
https://issues.apache.org/jira/browse/DRILL-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908298#comment-16908298
]
ASF GitHub Bot commented on DRILL-7350:
---------------------------------------
paul-rogers commented on pull request #1843: DRILL-7350: Move RowSet related
classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314400385
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/package-info.java
##########
@@ -32,6 +32,22 @@
* batch" or "record batch." (But, in Drill, the term "record batch" also
* usually means an operator on that set of records. Here, a row set is
* just the rows &nash; separate from operations on that data.</dd>
+ * <dt>SingleRowSet (abstract)</dt>
Review comment:
See general comment. Please do not combine the RowSet and ResultSetLoader
classes into a single package: they present very different models used for
different purposes.
Yes, it is confusing because there is no ResultSetReader at present, but
there should be to handle schema changes, etc. across batches. RowSet handles
only a single row set such as in tests. It was deliberately designed to NOT be
ResultSetReader solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Move RowSet related classes from test folder
> --------------------------------------------
>
> Key: DRILL-7350
> URL: https://issues.apache.org/jira/browse/DRILL-7350
> Project: Apache Drill
> Issue Type: Task
> Reporter: Volodymyr Vysotskyi
> Assignee: Volodymyr Vysotskyi
> Priority: Major
> Fix For: 1.17.0
>
>
> Move RowSet related classes from test folder to main to be able to use them
> for Metastore.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
