[
https://issues.apache.org/jira/browse/DRILL-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908289#comment-16908289
]
ASF GitHub Bot commented on DRILL-7350:
---------------------------------------
paul-rogers commented on pull request #1843: DRILL-7350: Move RowSet related
classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314395723
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/AbstractRowSet.java
##########
@@ -41,13 +38,19 @@ public AbstractRowSet(VectorContainer container,
TupleMetadata schema) {
}
@Override
- public VectorAccessible vectorAccessible() { return container(); }
+ public VectorAccessible vectorAccessible() {
Review comment:
Why change formatting? Drill has long used single-line methods for
conciseness. Is this an artifact of some code formatter? I didn't see
discussion on the dev list about changing our coding standards...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Move RowSet related classes from test folder
> --------------------------------------------
>
> Key: DRILL-7350
> URL: https://issues.apache.org/jira/browse/DRILL-7350
> Project: Apache Drill
> Issue Type: Task
> Reporter: Volodymyr Vysotskyi
> Assignee: Volodymyr Vysotskyi
> Priority: Major
> Fix For: 1.17.0
>
>
> Move RowSet related classes from test folder to main to be able to use them
> for Metastore.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
