[
https://issues.apache.org/jira/browse/DRILL-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908291#comment-16908291
]
ASF GitHub Bot commented on DRILL-7350:
---------------------------------------
paul-rogers commented on pull request #1843: DRILL-7350: Move RowSet related
classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314397062
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/DirectRowSet.java
##########
@@ -45,21 +45,10 @@
public class DirectRowSet extends AbstractSingleRowSet implements
ExtendableRowSet {
- public static class RowSetWriterBuilder extends BaseWriterBuilder {
-
- public RowSetWriterBuilder(ColumnConversionFactory conversionFactory) {
- super(conversionFactory);
- }
-
- public RowSetWriter buildWriter(DirectRowSet rowSet) {
- WriterIndexImpl index = new WriterIndexImpl();
- TupleMetadata schema = rowSet.schema();
- RowSetWriterImpl writer = new RowSetWriterImpl(rowSet, schema, index,
- buildContainerChildren(rowSet.container(),
- new MetadataRetrieval(schema)));
- return writer;
- }
- }
+ /**
+ * Initial row count, used for preliminary memory allocation.
+ */
+ public static final int INITIAL_ROW_COUNT = 10;
Review comment:
See note above about removal of nested class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Move RowSet related classes from test folder
> --------------------------------------------
>
> Key: DRILL-7350
> URL: https://issues.apache.org/jira/browse/DRILL-7350
> Project: Apache Drill
> Issue Type: Task
> Reporter: Volodymyr Vysotskyi
> Assignee: Volodymyr Vysotskyi
> Priority: Major
> Fix For: 1.17.0
>
>
> Move RowSet related classes from test folder to main to be able to use them
> for Metastore.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
