[ https://issues.apache.org/jira/browse/DRILL-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16972338#comment-16972338 ]
ASF GitHub Bot commented on DRILL-7442: --------------------------------------- vvysotskyi commented on pull request #1897: DRILL-7442: Create multi-batch row set reader URL: https://github.com/apache/drill/pull/1897#discussion_r345165787 ########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/RowSet.java ########## @@ -98,6 +98,8 @@ SelectionVectorMode indirectionType(); + void print(); Review comment: In DRILL-7350 we agreed to avoid providing methods for printing output to the stdout in non-test code, but provide `toString()` implementation where required. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create multi-batch row set reader > --------------------------------- > > Key: DRILL-7442 > URL: https://issues.apache.org/jira/browse/DRILL-7442 > Project: Apache Drill > Issue Type: Improvement > Reporter: Paul Rogers > Assignee: Paul Rogers > Priority: Minor > > The "row set" work provided a {{RowSetWriter}} and {{RowSetReader}} to write > to and read from a single batch. The {{ResultSetLoader}} class provided a > writer that spans multiple batches, handling schema changes across batches > and so on. > This ticket introduces a reader equivalent, the {{ResultSetReader}} that > reads an entire result set of multiple batches, handling schema changes along > the way. -- This message was sent by Atlassian Jira (v8.3.4#803005)