[ https://issues.apache.org/jira/browse/DRILL-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16972340#comment-16972340 ]
ASF GitHub Bot commented on DRILL-7442: --------------------------------------- vvysotskyi commented on pull request #1897: DRILL-7442: Create multi-batch row set reader URL: https://github.com/apache/drill/pull/1897#discussion_r345171072 ########## File path: exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/reader/AbstractTupleReader.java ########## @@ -87,6 +87,13 @@ public void bindNullState(NullStateReader nullStateReader) { this.nullStateReader = nullStateReader; } + @Override + public void rebind() { + for (int i = 0; i < readers.length; i++) { + readers[i].events().rebind(); + } Review comment: It can be rewritten with a for-each loop: ``` for (AbstractObjectReader reader : readers) { reader.events().rebind(); } ``` There is no difference from the performance perspective, but it would be easier to support this code in the future, for example when replacing array with a list, etc. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create multi-batch row set reader > --------------------------------- > > Key: DRILL-7442 > URL: https://issues.apache.org/jira/browse/DRILL-7442 > Project: Apache Drill > Issue Type: Improvement > Reporter: Paul Rogers > Assignee: Paul Rogers > Priority: Minor > > The "row set" work provided a {{RowSetWriter}} and {{RowSetReader}} to write > to and read from a single batch. The {{ResultSetLoader}} class provided a > writer that spans multiple batches, handling schema changes across batches > and so on. > This ticket introduces a reader equivalent, the {{ResultSetReader}} that > reads an entire result set of multiple batches, handling schema changes along > the way. -- This message was sent by Atlassian Jira (v8.3.4#803005)