[
https://issues.apache.org/jira/browse/DRILL-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16974140#comment-16974140
]
ASF GitHub Bot commented on DRILL-7442:
---------------------------------------
vvysotskyi commented on pull request #1897: DRILL-7442: Create multi-batch row
set reader
URL: https://github.com/apache/drill/pull/1897#discussion_r346245865
##########
File path:
exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/reader/AbstractTupleReader.java
##########
@@ -87,6 +87,13 @@ public void bindNullState(NullStateReader nullStateReader) {
this.nullStateReader = nullStateReader;
}
+ @Override
+ public void rebind() {
+ for (int i = 0; i < readers.length; i++) {
+ readers[i].events().rebind();
+ }
Review comment:
Actually, at least Java 8 rewrites for-each loop for array into the for-i
loop, here is an example of the source code and decompiled code:
```
String[] arr = {"a", "b", "c"};
for (String x : arr) {
System.out.println(x);
}
```
code after decompilation:
```
String[] var1 = new String[]{"a", "b", "c"};
String[] var2 = var1;
int var3 = var1.length;
for(int var4 = 0; var4 < var3; ++var4) {
String var5 = var2[var4];
System.out.println(var5);
}
```
But anyway, this is a minor comment, so the code may be left as it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Create multi-batch row set reader
> ---------------------------------
>
> Key: DRILL-7442
> URL: https://issues.apache.org/jira/browse/DRILL-7442
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Minor
>
> The "row set" work provided a {{RowSetWriter}} and {{RowSetReader}} to write
> to and read from a single batch. The {{ResultSetLoader}} class provided a
> writer that spans multiple batches, handling schema changes across batches
> and so on.
> This ticket introduces a reader equivalent, the {{ResultSetReader}} that
> reads an entire result set of multiple batches, handling schema changes along
> the way.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
