[ 
https://issues.apache.org/jira/browse/DRILL-8117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513167#comment-17513167
 ] 

ASF GitHub Bot commented on DRILL-8117:
---------------------------------------

kingswanwho commented on a change in pull request #2499:
URL: https://github.com/apache/drill/pull/2499#discussion_r836006194



##########
File path: 
exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestInboundImpersonation.java
##########
@@ -156,22 +159,25 @@ public void unauthorizedTarget() throws Exception {
 
   @Test
   public void invalidPolicy() throws Exception {
-    thrownException.expect(new 
UserExceptionMatcher(UserBitShared.DrillPBError.ErrorType.VALIDATION,
-        "Invalid impersonation policies."));
+    String query = "ALTER SYSTEM SET `%s`='%s'";

Review comment:
       Hi Paul, it does really help! I will replace all those hard-code by 
client in this PR, thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


> Clean up deprecated Apache code in Drill
> ----------------------------------------
>
>                 Key: DRILL-8117
>                 URL: https://issues.apache.org/jira/browse/DRILL-8117
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Jingchuan Hu
>            Priority: Major
>
> Clean up and upgrade deprecated Apache code like: 
> Class PathChildrenCache in Class ZookeeperClient and Class StringEscapeUtils 
> in Class PlanStringBuilder
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to