[
https://issues.apache.org/jira/browse/DRILL-8117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523436#comment-17523436
]
ASF GitHub Bot commented on DRILL-8117:
---------------------------------------
kingswanwho commented on code in PR #2499:
URL: https://github.com/apache/drill/pull/2499#discussion_r851795975
##########
exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestInboundImpersonation.java:
##########
@@ -156,22 +159,25 @@ public void unauthorizedTarget() throws Exception {
@Test
public void invalidPolicy() throws Exception {
- thrownException.expect(new
UserExceptionMatcher(UserBitShared.DrillPBError.ErrorType.VALIDATION,
- "Invalid impersonation policies."));
+ String query = "ALTER SYSTEM SET `%s`='%s'";
Review Comment:
@paul-rogers Hi Paul, I am sorry that I dragged this PR out too long. I
replaced hard-code to FixtureClient, but UT failed due to the Error:
`java.lang.AssertionError: unexpected exception type thrown;
expected:<org.apache.drill.common.exceptions.UserException> but
was:<java.lang.IllegalStateException>
at
org.apache.drill.exec.impersonation.TestInboundImpersonation.invalidProxy(TestInboundImpersonation.java:186)
Caused by: java.lang.IllegalStateException:
org.apache.drill.common.exceptions.UserRemoteException: PERMISSION ERROR:
Cannot change option exec.impersonation.inbound_policies in scope SESSION`
I think the two clients cannot exist at the same time, so I changed back to
the hard-code way.
> Clean up deprecated Apache code in Drill
> ----------------------------------------
>
> Key: DRILL-8117
> URL: https://issues.apache.org/jira/browse/DRILL-8117
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Jingchuan Hu
> Priority: Major
>
> Clean up and upgrade deprecated Apache code like:
> Class PathChildrenCache in Class ZookeeperClient and Class StringEscapeUtils
> in Class PlanStringBuilder
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
